Fixes #3286: system items can not be modified like non-system ones #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +89,7 @@ class LDAPConfigurationRuleRepository( | |||
| con <- ldap | |||
| entry <- con.get(rudderDit.CONFIG_RULE.configRuleDN(id.value)) ?~! "Configuration rule with ID '%s' is not present".format(id.value) | |||
| oldCr <- mapper.entry2ConfigurationRule(entry) ?~! "Error when transforming LDAP entry into a Configuration Rule for id %s. Entry: %s".format(id, entry) | |||
| isSytem <- if(oldCr.isSystem) Failure("Deleting system rule '%s (%s)' is forbiden".format(oldCr.name, oldCr.id.value)) else Full("OK") | |||
There was a problem hiding this comment.
This looks like a typo to me - not sure if it has any impact, but still, I though it was worth mentioning, since everywhere else this is "isSystem".
There was a problem hiding this comment.
It is, even if it does not have any impact, since it's a fresh variable name here.
|
Looks great, thanks for the improvement |
ncharles
added a commit
that referenced
this pull request
Mar 19, 2013
…_be_modifiable_by_public_api Fixes #3286: system items can not be modified like non-system ones
fanf
deleted the
bug_3286/dev/system_item_should_not_be_modifiable_by_public_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.