Fixes #9802: Error when displaying Rules when a rule is applying a directive that does not exists anymore #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Dec 13, 2016
| @@ -542,7 +542,7 @@ class RuleGrid( | |||
| val t0 = System.currentTimeMillis | |||
|
|
|||
| val nodes = groupsLib.getNodeIds(line.rule.targets, nodesInfo) | |||
| val (policyMode,explanation) = ComputePolicyMode.ruleMode(globalMode, line.rule.directiveIds.map(directiveLib.allDirectives(_)).map(_._2)) | |||
| val (policyMode,explanation) = ComputePolicyMode.ruleMode(globalMode, line.rule.directiveIds.map(directiveLib.allDirectives.get(_)).flatMap(_.map(_._2))) | |||
There was a problem hiding this comment.
Could you add a comment sating what is the will here?
Something like:
"We don't fail on missing directive. Most likelly a deleted directive link wasn't updated correctly. We should assure consistency on all rudder config elem, but until that (big) change, it seems to be the most resilient solution".
…rective that does not exists anymore
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_9802/error_when_displaying_rules_when_a_rule_is_applying_a_directive_that_does_not_exists_anymore
branch
from
f272b86
to
99e0506
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9802