Fixes #9734: Store tags on Directives/Rules #1410
Conversation
|
Commit modified |
ncharles
force-pushed
the
ust_9734/store_tags_on_directives_rules
branch
from
0e2901d
to
548f168
Compare
|
Commit modified |
ncharles
force-pushed
the
ust_9734/store_tags_on_directives_rules
branch
from
548f168
to
bc23eda
Compare
| /** | ||
| * We can have multiple Tags with same name - unicity is really on TagName + TagValue | ||
| */ | ||
| final case class Tags( |
There was a problem hiding this comment.
Do we need that class ? what is the advantage of having a 'Tags' instead of a 'Set[Tags]' directly in our objects ?
There was a problem hiding this comment.
I don't know what would be the advantage. It is more verbose, and the only possible advantage might be that one day Tags would be different, and so it wouild encapsulate change; but this is dubious
Should I drop it ?
There was a problem hiding this comment.
I would have removed it yes!
There was a problem hiding this comment.
Actually, having the Tags class let me define in one location only the rules on unicities - so if we want to change in the future the rules on tags, it'll be easier
so i favour keeping the Tags class
|
Apart the question on the Tags type, that can be merged ! |
|
OK, merging this PR |
|
OK, merging this PR |
No description provided.