Fixes #9885: In group page, remove reference to CFEngine in generated classes #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooooooon
reviewed
Jan 2, 2017
| @@ -177,7 +177,7 @@ class NodeGroupForm( | |||
| "rudderid" -> <div><b class="threeCol">Rudder ID: </b>{nodeGroup.id.value}</div>, | |||
| "cfeclasses" -> <div> | |||
| <a href="#" onclick={s"$$('#cfe-${nodeGroup.id.value}').toggle(300); return false;"}> | |||
| <b class="threeCol">Display CFEngine classes</b> | |||
| <b class="threeCol">Display classes generated for this group</b> | |||
There was a problem hiding this comment.
I think that's a bit long. How about "Display conditional classes"
There was a problem hiding this comment.
Love to have a shorter / lighter thing.
Why not for "conditional". (but maybe people will not understand where it can be used)
My idea; "display agent classes", what do you think of it ?
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_9885/in_group_page_remove_reference_to_cfengine_in_generated_classes
branch
from
10de26a
to
c669cd0
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9885