Fixes #10157: Add an option to not display rule status/recent changes in directives screen #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, it seems that github don't want to let me edit the head description. So it is WIP, no real test done for now. |
|
PR rebased |
fanf
force-pushed
the
ust_10157/add_an_option_to_not_display_rule_status_recent_changes_in_directives_screen
branch
from
3418432
to
31d92bb
Compare
|
PR rebased |
fanf
force-pushed
the
ust_10157/add_an_option_to_not_display_rule_status_recent_changes_in_directives_screen
branch
from
31d92bb
to
a811d67
Compare
|
PR rebased |
fanf
force-pushed
the
ust_10157/add_an_option_to_not_display_rule_status_recent_changes_in_directives_screen
branch
from
a811d67
to
d063aca
Compare
|
PR rebased |
fanf
force-pushed
the
ust_10157/add_an_option_to_not_display_rule_status_recent_changes_in_directives_screen
branch
from
d063aca
to
a64a009
Compare
| , showRulePopup : (Option[Rule]) => JsCmd | ||
| , showRulePopup : (Option[Rule]) => JsCmd | ||
| , columnCompliance : DisplayColumn | ||
| , graphRecentChanges : DisplayColumn |
There was a problem hiding this comment.
':' Not correctly aligned :)
| @@ -152,6 +154,8 @@ function generateRecentGraph(id, displayGraph) { | |||
|
|
|||
| function recentChangesText(id) { | |||
|
|
|||
| console.log("Writting as text " + id); | |||
| @@ -116,6 +116,8 @@ function computeChangeGraph(changes, id, currentRowsIds, changeCount, displayGra | |||
|
|
|||
| function generateRecentGraph(id, displayGraph) { | |||
| if (displayGraph) { | |||
| console.log("Writting as graph " + id); | |||
|
Apart the litlle remarks it's ok to me! |
… in directives screen
|
PR rebased |
fanf
force-pushed
the
ust_10157/add_an_option_to_not_display_rule_status_recent_changes_in_directives_screen
branch
from
a64a009
to
0dbb536
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
2 similar comments
|
OK, merging this PR |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10157