Fixes #10250: When trying to create a new API account that has the same name as an existing acocunt, nothing happen #1522
Conversation
| @@ -118,7 +118,15 @@ <h1 id="title" style="color: #000; wrap-word:break-word;">{{formTitle(myNewAccou | |||
| <div class="simplemodal-bottom"> | |||
| <div class="popupButton" style="width: 98%;border-top: 1px solid #9A9A9A;margin-top: 10px;"> | |||
| <span> | |||
| <input type="submit" class="btn-primary" style="float:right;" value="Save" ng-disabled="newAccount.$pristine || newAccount.$invalid" ng-click="checkAndSaveAccount(myNewAccount,myNewAccount.index,newAccount);newAccount.$setPristine();" /> | |||
| <button | |||
There was a problem hiding this comment.
Why changing from input to button fix it ?
We should put the check in the ng-disable i think ... but htat for another time :)
There was a problem hiding this comment.
Oops, this was just a test. I forgot to replace it...
There was a problem hiding this comment.
Then i don't understand what is fixing the issue here :(
There was a problem hiding this comment.
The angular app was started twice in a row :
- with the ng-app directive (<div class="portlet" ng-app="accountManagement" [...]>)
- with : angular.bootstrap(document.getElementById('accountManagement'), ['accountManagement']);
This caused a JS error which was the origin of this bug
There was a problem hiding this comment.
I simply removed the ngApp directive!
|
This PR is not mergeable to upper versions. |
…me name as an existing acocunt, nothing happen
|
Commit modified |
RaphaelGauthier
force-pushed
the
bug_10250/when_trying_to_create_a_new_api_account_that_has_the_same_name_as_an_existing_acocunt_nothing_happen
branch
from
866f0d0
to
7dd23e4
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/10250