Fixes #10301: Remove "rights" in node property #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Full(updateOrRemoveProp(newProp)) | ||
| } | ||
| } else { | ||
| Failure(s"You are trying to update the following property which is owned by an other provider, '${provider.map(_.value).getOrElse("")}': '${name}'") |
There was a problem hiding this comment.
Maybe it would be interesting to state here which provider you are we only display the current provider )
There was a problem hiding this comment.
and state "undefined" or "unknown" instead of empty value in the getOrElse
|
That will also need a PR in plugin datasource which will not compile (it set rights) |
|
Yep, I'm on it |
|
PR rebased |
fanf
force-pushed
the
bug_10301/remove_rights_in_node_property
branch
from
6af7f0c
to
462fac5
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10301