Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3433: allows to continue deployment on target node var lookup error #159

Closed
wants to merge 1 commit into from
Closed

Fixes #3433: allows to continue deployment on target node var lookup error #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 16 additions & 3 deletions ...c/main/scala/com/normation/rudder/services/policies/ParameterizedValueLookupService.scala
View file
Open in desktop
Expand Up @@ -338,9 +338,22 @@ trait ParameterizedValueLookupService_lookupRuleParameterization extends Paramet
}
nodeIds <- sequence(targets.toSeq){target => directiveTargetService.getNodeIds(target)}
cf1 = logger.trace("Fetched nodes ids : %s".format(nodeIds))
nodeInfos <- sequence(nodeIds.flatten.distinct) { nodeId =>
nodeInfoService.getNodeInfo(nodeId)
}

//here, we don't want to fail on missing node.
//that will be handle in cardinality check
nodeInfos = ( (nodeIds.flatten.distinct).flatMap { nodeId =>
val info = nodeInfoService.getNodeInfo(nodeId)
info match {
case eb:EmptyBox => //log
val e = eb ?~! "Can not lookup accessor %s on node %s".format(targetAccessorName, nodeId.value)
logger.warn(e)
e.rootExceptionCause.foreach { ex =>
logger.warn("Root exception was: ", ex)
}
case _ => //nothing
}
info
} )
cf2 = logger.trace("Fetched nodes infos : %s".format(nodeInfos))
cardinalityOk <- {
if(!sourceVariableSpec.multivalued && nodeInfos.size != 1)
Expand Down