Fixes #10451: A running Policy generation is not displayed on the Status dropdown #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
Mar 23, 2017
| @@ -132,6 +132,12 @@ class AsyncDeployment extends CometActor with CometListener with Loggable { | |||
| <li><div id="deployment-end">{displayTime("Ended at ", end)}</div></li> | |||
| <li class="dropdown-header" style="border-bottom-style: dotted; border-color: gray;">{durationText} {DateFormaterService.getFormatedPeriod(start,end)}</li> | |||
| } | |||
| def loadingStatement(start : DateTime) = { | |||
| <li class="dropdown-header">Policies building...</li> | |||
| <li>{displayTime("Started at ", start)}</li> | |||
There was a problem hiding this comment.
I believe we can't use the "start" method here, because with it, we have "Started at blablabla -> 1s ago". But the "1s ago" never changes, and so it is extremelly misleading.
So we need to only display the part with the date.
|
Commit modified |
RaphaelGauthier
force-pushed
the
bug_10451/a_running_policy_generation_is_not_displayed_on_the_status_dropdown
branch
from
a8d221c
to
2b698fb
Compare
|
I think you misunderstood. We need to keep the start DATE, but not the "↳", because the DURATION won't be updated, and even after a couple of minute, we have "↳ less than 1 s ago", which is misleading because people will thought they can use that to measure the duration, but actually not. So please, keep the line with the "Started at 2017-03-24 12:36:38" |
|
Commit modified |
RaphaelGauthier
force-pushed
the
bug_10451/a_running_policy_generation_is_not_displayed_on_the_status_dropdown
branch
from
2b698fb
to
9dbfcc5
Compare
fanf
approved these changes
Mar 24, 2017
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10451