Fixes #10569: Adding a json node property by UI make it a string #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Apr 13, 2017
| @@ -636,6 +636,7 @@ case class RestExtractorService ( | |||
| private[this] def extractNodeProperty(json : JValue) : Box[NodeProperty] = { | |||
| ( (json \ "name"), (json \ "value") ) match { | |||
| case ( JString(nameValue), value ) => | |||
| logger.info(value) | |||
There was a problem hiding this comment.
it should either be debug, or not there, isn't it?
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_10569/adding_a_json_node_property_by_ui_make_it_a_string
branch
from
a2534eb
to
5887212
Compare
|
I cannot add node properties with this change :( |
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_10569/adding_a_json_node_property_by_ui_make_it_a_string
branch
from
5887212
to
0f9d9df
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_10569/adding_a_json_node_property_by_ui_make_it_a_string
branch
from
0f9d9df
to
c914240
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10569