-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8017: Adding an authorized network when "common-root" directive is missing seems to work, but actually fails #1649
Fixes #8017: Adding an authorized network when "common-root" directive is missing seems to work, but actually fails #1649
Conversation
…ive is missing seems to work, but actually fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing early when system directives are not there is indeed the right solution.
However, i'd like to have consistency between advertised variables in config file and the hardcoding here
@@ -141,6 +143,37 @@ class CheckDIT( | |||
case Full(_) => //ok | |||
} | |||
|
|||
//check Root Policy Server entries (from init-policy-server.ldif) | |||
val dns = List( | |||
"nodeId=root,ou=Nodes,cn=rudder-configuration" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have properties in config file for these
We should either use the properties, or either say they should never touched/used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so... What properties are you talking about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, rudder base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the config file is lying, because rudder-init does care at all of these properties.
This PR is not mergeable to upper versions. |
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/8017