Fixes #8017: Adding an authorized network when "common-root" directive is missing seems to work, but actually fails #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive is missing seems to work, but actually fails
ncharles
reviewed
Apr 27, 2017
| @@ -141,6 +143,37 @@ class CheckDIT( | |||
| case Full(_) => //ok | |||
| } | |||
|
|
|||
| //check Root Policy Server entries (from init-policy-server.ldif) | |||
| val dns = List( | |||
| "nodeId=root,ou=Nodes,cn=rudder-configuration" | |||
There was a problem hiding this comment.
we have properties in config file for these
We should either use the properties, or either say they should never touched/used
There was a problem hiding this comment.
I don't think so... What properties are you talking about?
There was a problem hiding this comment.
Well, the config file is lying, because rudder-init does care at all of these properties.
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
fanf
deleted the
bug_8017/adding_an_authorized_network_when_common_root_directive_is_missing_seems_to_work_but_actually_fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8017