Fixes #10842: Update write test for 4.1 and add generation for a node #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val pathComputer = new PathComputerImpl( | ||
| SHARE.getParent + "/" | ||
| , SHARE.getName | ||
| , abstractRoot.getAbsolutePath + "/backup" |
There was a problem hiding this comment.
no prob if backup is the same for different label ?
There was a problem hiding this comment.
it doesn't seems to care. And at least for the generation part, it does not seems to matter.
|
|
||
| //////////// end init //////////// | ||
|
|
||
| //////////// set-up auto test cleaning //////////// | ||
| override def afterAll(): Unit = { | ||
| if(System.getProperty("tests.clean.tmp") != "false") { | ||
| if(false) { // System.getProperty("tests.clean.tmp") != "false") { |
There was a problem hiding this comment.
Remove dead code (or set back condition)
|
PR rebased |
fanf
force-pushed
the
arch_10842/update_write_test_for_4_1_and_add_generation_for_a_node
branch
from
9ef8d0f
to
971dacc
Compare
|
I see noihing strange or invaluid apart the small remarks, merging |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10842