Fixes #10927: Create system variables for apache authentication #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Jun 21, 2017
| val nodesWithCertificate = nodesAgentWithCertificate.flatMap {case (agent, node) => | ||
| agent.securityToken match { | ||
| // A certificat, we return it | ||
| case cert:Certificate => Some(node -> cert) |
There was a problem hiding this comment.
you should return here (cert, cert.cert) because parsing cert is expensive, so better doing only one time
|
Commit modified |
ncharles
force-pushed
the
arch_10927/create_system_variables_for_apache_authentication
branch
from
7458a47
to
a938665
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10927