Fixes #11191: Add a post-node-acceptation hook #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Jul 28, 2017
| postHooks <- RunHooks.getHooks(HOOKS_D + "/node-post-acceptance", HOOKS_IGNORE_SUFFIXES) | ||
| runPostHook = RunHooks.syncRun(postHooks, hookEnv, systemEnv) | ||
| timePostHooks = (System.currentTimeMillis - postHooksTime) | ||
| _ = logger.debug(s"Node-post-deletion scripts hooks ran in ${timePostHooks} ms") |
| @@ -0,0 +1,16 @@ | |||
| = policy-generation-node-finished | |||
There was a problem hiding this comment.
shouldn't it be node-post-acceptance ?
|
I didn't wanted to put it in 4.1 because the feature is half-backed (no pre-node acceptance, not sure about the parameters passed to scripts) and I would prefer to have a real relection done on that subject before considering adding it to 4.1. |
fanf
force-pushed
the
bug_11191/add_a_post_node_acceptation_hook
branch
from
3fb86dc
to
1372d62
Compare
|
PR rebased |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11191