Fixes #11291: Highlight DSC compatible technique versions in the available versions table. #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
requested changes
Aug 25, 2017
| @@ -355,16 +356,21 @@ class DirectiveManagement extends DispatchSnippet with Loggable { | |||
| val isDeprecated = t.deprecrationInfo.isDefined | |||
| val deprecationMessage = t.deprecrationInfo.map(_.message).getOrElse("") | |||
| val acceptationDate = DateFormaterService.getFormatedDate(timeStamp) | |||
| val dscSupport = t.agentConfigs.forall { _.agentType match{ | |||
There was a problem hiding this comment.
Why forall ? this means that all agentTYpe should be dsc, use exists instead!!
…lable versions table.
|
Commit modified |
RaphaelGauthier
force-pushed
the
ust_11291/highlight_dsc_compatible_technique_versions_in_the_available_versions_table
branch
from
f855ba4
to
7dc2b83
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11291