Fixes #11326: chars are not escaped correctly in dsc techniques #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Sep 15, 2017
| if (x == null) | ||
| x | ||
| else | ||
| x.replaceAll("""\\""", """\\\\""").replaceAll(""""""", """\\"""") | ||
| agentType match { | ||
| case AgentType.Dsc => x.replaceAll("`", "``").replaceAll("\"", "`\"") |
There was a problem hiding this comment.
can you correct the indentation ? :)
There was a problem hiding this comment.
why is it " that we escape, rather than simply " ?
There was a problem hiding this comment.
" is escaped because it's a double quote string, so to contains a " it needs to be escaped
fanf
reviewed
Sep 15, 2017
| @@ -802,6 +802,7 @@ trait PromiseGeneration_buildNodeConfigurations extends PromiseGenerationService | |||
| (name, p) | |||
| } | |||
| } | |||
| agent <- Box(context.nodeInfo.agentsName.headOption) ?~! "Should not be Empty" | |||
There was a problem hiding this comment.
"Should not be Empty" => "The agent type is not defined. Please, report it, it is most likelly a bug".
|
Appart for the 2 little remarks, it's ok. You can correct and label for merge on your own. |
|
PR rebased |
VinceMacBuche
force-pushed
the
bug_11326/chars_are_not_escaped_correctly_in_dsc_techniques
branch
from
5e2bf1d
to
0bec59e
Compare
|
Closing, wrong target branch |
|
replaced by #1737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11326