Fixes #10719: Remove the skipidentify variable and settings page entry #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extends SettingsApi with Loggable { | ||
|
|
||
|
|
||
| val allSettings = |
There was a problem hiding this comment.
I would have put the list in the SettingsAPI in a val (baseSettings) and remove or add skipidentify
I would go for baseSettings to be api v9 list
in v9 allSettings = baseSettings
in v8 allSettings = baseSettings :+ RestUseReverseDNS
|
Apart the small refactoring remark, this is great ! thanks Nicolas ! |
|
Commit modified |
ncharles
force-pushed
the
arch_10719/remove_the_skipidentify_variable_and_settings_page_entry
branch
from
3f733f6
to
edfd0e8
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10719