Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12093: Make Rudder UI pluggable (login + common layout) #1849

Merged
merged 2 commits into from Feb 14, 2018
Merged

Fixes #12093: Make Rudder UI pluggable (login + common layout) #1849

merged 2 commits into from Feb 14, 2018

Conversation

VinceMacBuche
Copy link
Member

ncharles
ncharles requested changes Feb 8, 2018
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, but you need to rebase commit
Plus, the closing of tags should be backported to 4.1

rudder-web/src/main/scala/bootstrap/liftweb/AppConfig.scala
@@ -1753,6 +1753,7 @@ object RudderConfig extends Loggable {
}

val aggregateReportScheduler = new FindNewReportsExecution(executionService,RUDDER_REPORTS_EXECUTION_INTERVAL)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great change :)

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 0af0377 into Normation:branches/rudder/4.3 Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles requested changes

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@VinceMacBuche @Normation-Quality-Assistant @fanf @ncharles