Fixes #12106: Implement general parameters for policy server policy c… #1857
Conversation
| @@ -551,7 +615,12 @@ <h3>Protocol</h3> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <<<<<<< HEAD | |||
| private[this] implicit def toRelaySynchronisationMethod(p: RudderWebProperty): RelaySynchronizationMethod = p.value match { | ||
| case ClassicSynchronization.value => ClassicSynchronization | ||
| case RsyncSynchronization.value => RsyncSynchronization | ||
| case DisabledSynchronization.value => DisabledSynchronization |
There was a problem hiding this comment.
Heren the match is not exhaustive. If the value is not recognized, it will fails.
I thing we want to have "classic" as the default, so use:
case RsyncSynchronization.value => RsyncSynchronization
case DisabledSynchronization.value => DisabledSynchronization
case _ => ClassicSynchronization
| @@ -188,6 +193,10 @@ object TestSystemData { | |||
| //denybadclocks and skipIdentify are runtime properties | |||
| , getDenyBadClocks = () => Full(true) | |||
| , getSkipIdentify = () => Full(false) | |||
| // relay synchronisation method | |||
| , getSyncMethod = () => Full(ClassicSynchronization) | |||
| , getSyncPromises = () => Full(false) | |||
There was a problem hiding this comment.
Does it makes sense (from the feature behavior) to have separated items for sync method / sync promises / sync shared file ? The two last seems to have a meaning only for syncMethod=rsync, no ? (really asking, I don't have any idea from the ticket description about what should be the behavior)
There was a problem hiding this comment.
for the moment they have, but it could change in the future - to have rsync for one, and classic for another for instance
I didn't want to go the json path for something that were bound to change , and I prefered to stricly match the form and the system variable
|
Ho, you also need to update the API for settings to handle the new properties |
ncharles
force-pushed
the
ust_12106/general_parameters_for_relay_synchro
branch
from
6790104
to
3405fa6
Compare
|
Commit modified |
ncharles
force-pushed
the
ust_12106/general_parameters_for_relay_synchro
branch
from
3405fa6
to
d42f740
Compare
|
Commit modified |
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
1 similar comment
|
OK, merging this PR |
…opy for nodes