Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11946: Interface to manage API account authorization #1867

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche
Copy link
Member Author

PR rebased

@VinceMacBuche VinceMacBuche force-pushed the ust_11946/interface_to_manage_api_account_authorization branch from e1a00c3 to 46bebf3 Compare March 9, 2018 15:51
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You renamed several html files from "secure" to "javascript" by mistake.
Also: We must have a column with the account access rights (ame label than in the edit drop down)
Some more things that can go in a post-beta2 round:

  • bad css for previous/next grid buttons
  • validity expiration behave unconsistantly:
    • on creation, we should have the current date + one month pre-filled (defautl value)
    • we should have a checkbox for expiration date to be able to disable it (for now, impossible to disable it if enabled)

Also, the desciption on mouse over is a nive add :)

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the ust_11946/interface_to_manage_api_account_authorization branch from 46bebf3 to bf6b544 Compare March 10, 2018 15:47
@fanf
Copy link
Member

fanf commented Mar 12, 2018

Approving that one, things in https://www.rudder-project.org/redmine/issues/12202 would need to be corrected. And we will have to do or find a way to delegate things described in https://www.rudder-project.org/redmine/issues/12203

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/1867
-- Your faithful QA

@fanf
Copy link
Member

fanf commented Mar 12, 2018

OK, merging this PR

@fanf fanf merged commit bf6b544 into Normation:branches/rudder/4.3 Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants