Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12332: Wrong api method name #1886

Closed
wants to merge 1 commit into from
Closed

Fixes #12332: Wrong api method name #1886

wants to merge 1 commit into from

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Apr 3, 2018

@VinceMacBuche
Copy link
Member

VinceMacBuche commented Apr 9, 2018 •
edited

Can you rbease your pull request @Fdall ? :) only keep the last commit!

@Fdall Fdall force-pushed the bug_12332/wrong_api_method_name branch from 3416a67 to 80a9d62 Compare April 9, 2018 09:06
@Fdall
Copy link
Contributor Author

Fdall commented Apr 9, 2018

Commit modified

@Fdall Fdall force-pushed the bug_12332/wrong_api_method_name branch from 80a9d62 to 5376585 Compare April 9, 2018 09:11
@Fdall
Copy link
Contributor Author

Fdall commented Apr 9, 2018

Commit modified

VinceMacBuche
VinceMacBuche requested changes Apr 9, 2018
View reviewed changes
Copy link
Member

@VinceMacBuche VinceMacBuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in rudder-api-doc

@fanf
Copy link
Member

fanf commented Apr 9, 2018

I let a comment on that one here: https://www.rudder-project.org/redmine/issues/12332#note-4

@Fdall Fdall closed this Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Fdall @VinceMacBuche @fanf