Fixes #12730: Moving policies to their final position (last step of policies writing) could be improved #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olicies writing) could be improved
ncharles
commented
May 31, 2018
| @@ -670,8 +670,8 @@ class Cf3PromisesFileWriterServiceImpl( | |||
| if (src.isDirectory()) { | |||
| val dest = new File(backupFolder) | |||
| if (dest.isDirectory) { | |||
| // force deletion of previous backup | |||
| FileUtils.forceDelete(dest) | |||
There was a problem hiding this comment.
the first call of forceDelete is to check if parameter is a directory, and if so, call deleteDirectory
This won't be a big change at all, but it'll be a small dropplet in the ocean od possible improvement
fanf
approved these changes
Jun 6, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12730