Fixes #12808: Rudder API for ACL is buggy #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
bug_12808/rudder_api_for_acl_is_buggy
branch
from
c3fd73e
to
2fb4f8c
Compare
|
PR rebased |
1 similar comment
|
PR rebased |
fanf
force-pushed
the
bug_12808/rudder_api_for_acl_is_buggy
branch
2 times, most recently
from
4b5c6d1
to
2af412c
Compare
|
PR rebased |
fanf
force-pushed
the
bug_12808/rudder_api_for_acl_is_buggy
branch
from
2ef9275
to
1b86a42
Compare
|
PR rebased |
| success(function(data, status, headers, config) { | ||
| var newAccount = data.data.accounts[0]; | ||
| $scope.accounts[$scope.myNewAccount.index] = newAccount | ||
| console.log("account") |
There was a problem hiding this comment.
You can remove the console.log :)
|
PR rebased |
fanf
force-pushed
the
bug_12808/rudder_api_for_acl_is_buggy
branch
from
1b86a42
to
ba41803
Compare
| @@ -1176,10 +1176,7 @@ class PropertiesManagement extends DispatchSnippet with Loggable { | |||
| ) | |||
| } & | |||
| "#unexpectedReportInterpretationFormSubmit " #> { | |||
| val x = SHtml.ajaxSubmit("Save changes", submit _, ("class","btn btn-default"), ("disabled", "disabled")) | |||
| println(x) | |||
VinceMacBuche
approved these changes
Jun 26, 2018
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12808