Fixes #13067: Update main menu: plugin at top level, techique editor in configuration policy #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase to remove wip commit please ? :) |
|
PR rebased |
fanf
force-pushed
the
ust_13067/move_the_plugins_menu_to_top_level
branch
from
79eb237
to
858b2cd
Compare
|
Should we add some redirect from old url to new ones ? |
VinceMacBuche
requested changes
Aug 31, 2018
| @@ -28,7 +28,21 @@ | |||
| select { | |||
| min-width:50px | |||
| } | |||
| .defaultButton span.ui-button-text { | |||
| .defaultButton span.ui-button-text { <div class="col-xs-12 callout-fade callout-warning"> | |||
There was a problem hiding this comment.
I don't think you want to add that in a css entry !! or i don't understand something :)
…in configuration policy
|
PR rebased |
fanf
force-pushed
the
ust_13067/move_the_plugins_menu_to_top_level
branch
from
858b2cd
to
4f889ee
Compare
VinceMacBuche
previously approved these changes
Aug 31, 2018
|
OK, merging this PR |
| @@ -65,6 +65,10 @@ import com.normation.rudder.rest.EndpointSchema | |||
| import com.normation.rudder.rest.{InfoApi => InfoApiDef} | |||
| import com.normation.rudder.rest.lift.InfoApi | |||
| import com.normation.rudder.rest.lift.LiftApiModuleProvider | |||
| import net.liftweb.sitemap.Loc.LocGroup | |||
There was a problem hiding this comment.
Too many imports but i already accepted the pr :( hope i was faster than merging bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13067