Fixes #13615: Bad explanation for generic variable overide priority cause people making the opposite of what is needed #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Oct 8, 2018
| <p>Unique Directives can be applied only once (ie. Time Settings), so only the highest priority will be appllied.</p> | ||
| <p>Priority has two uses depending if the technique from which that directive is derived is <b>Unique</b> or not.</p> | ||
| <p>Unique directives can be applied only once (for example Time Settings), so only the highest priority will be applied.</p> | ||
| <p>For <b>non-unique</b> directives, priority is used to choose the order of the directive linearisation when applicable. The |
There was a problem hiding this comment.
I don't think linearisation is clear for users. Maybe application?
|
PR rebased |
fanf
force-pushed
the
bug_13615/bad_explanation_for_generic_variable_overide_priority_cause_people_making_the_opposite_of_what_is_needed
branch
from
993b6aa
to
789c032
Compare
amousset
reviewed
Oct 8, 2018
| <p>Priority has two uses depending if the technique from which that directive is derived is <b>Unique</b> or not.</p> | ||
| <p>Unique directives can be applied only once (for example Time Settings), so only the highest priority will be applied.</p> | ||
| <p>For <b>non-unique</b> directives, priority is used to choose the order of the directive application when applicable. The | ||
| highest priority directive comes first. Note that overriding variables definitions are the ones coming last.</p> |
There was a problem hiding this comment.
Note that overriding variables definitions are the ones coming last.
.. so the used value will be the one with the lowest priority
…ause people making the opposite of what is needed
|
PR rebased |
fanf
force-pushed
the
bug_13615/bad_explanation_for_generic_variable_overide_priority_cause_people_making_the_opposite_of_what_is_needed
branch
from
789c032
to
4940c73
Compare
|
OK, merging this PR |
fanf
deleted the
bug_13615/bad_explanation_for_generic_variable_overide_priority_cause_people_making_the_opposite_of_what_is_needed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13615