Fixes #4709: When a node is deleted, its generated promises are not removed #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
bug_4709/when_a_node_is_deleted_it_s_generated_promises_are_not_removed
branch
from
befd4d4
to
117d22d
Compare
ncharles
reviewed
Nov 14, 2018
| # - RUDDER_AGENT_TYPE : agent type ("cfengine-nova" or "cfengine-community") | ||
| # - RUDDER_POLICIES_DIRECTORY_CURRENT: the full path of the base directory containing policies for that node | ||
| # - RUDDER_POLICIES_DIRECTORY_NEW: the full path of the base directory containing next policies for that node (during a generation) | ||
| # - RUDDER_POLICIES_DIRECTORY_ARCHIVE: the full path of the base directory containing previous policies for that node |
There was a problem hiding this comment.
we should remove this one also
peckpeck
reviewed
Nov 14, 2018
| # delete all generated policies for that node | ||
| NODE_DIR=$(dirname ${RUDDER_POLICIES_DIRECTORY_CURRENT}) | ||
|
|
||
| if [ -d ${NODE_DIR} ]; then |
fanf
force-pushed
the
bug_4709/when_a_node_is_deleted_it_s_generated_promises_are_not_removed
branch
from
117d22d
to
076a0e1
Compare
|
PR rebased |
…are not removed
|
PR rebased |
fanf
force-pushed
the
bug_4709/when_a_node_is_deleted_it_s_generated_promises_are_not_removed
branch
from
076a0e1
to
d78d15b
Compare
peckpeck
approved these changes
Nov 14, 2018
|
OK, merging this PR |
fanf
deleted the
bug_4709/when_a_node_is_deleted_it_s_generated_promises_are_not_removed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/4709