Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14004: Wasted disk space due to inefficient columns ordering #2099

Conversation

ncharles
Copy link
Member

@fanf
Copy link
Member

fanf commented Dec 19, 2018

There is several things in that PR and I'm not sure we want all of them, or all in master:

  • the idx name should be changed in 4.3, for new install only (ie no migration needed: old bases keep the old name, new base use the ones ok with convention),
  • the unused table should be removed in the first that does not use it, and at least 5.0 (new install will just not have it),
  • for the column order... Now that I see the extended modification, I'm not so much at ease with it anymore. It feels really unatural to have nodeid of other identification parts, sometime part of table key, to be in latter columns. This is very unusual and, even if it's likelly not a problem for us (rudder dev), it will be very strange for users or contributors.

If the gain are substantials, I believe we can argue for the change (with a lot of comments for impacted table about the rationnal). If they are not, I'm not sure the cost of surprise worth it.

@ncharles
Copy link
Member Author

ok, closing this PR. For the index, its because they are invalid (we are indexing 3 time the same column) ( see https://issues.rudder.io/issues/14007 )

@ncharles ncharles closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants