Fixes #14312: Missing eventlogs for technique editor action and technique update #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Mar 27, 2019
| @@ -592,7 +627,12 @@ class EventLogFactoryImpl( | |||
| , severity : Int = 100 | |||
| , reason : Option[String] | |||
| ) : DeleteTechnique = { | |||
| val details = EventLog.withContent(techniqueXmlSerializer.serialise(deleteDiff.technique) % ("changeType" -> "delete")) | |||
| val details = EventLog.withContent{ | |||
|
Commit modified |
ncharles
approved these changes
Mar 27, 2019
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_14312/missing_eventlogs_for_technique_editor_action_and_technique_update
branch
from
e27c4e8
to
7cf6d69
Compare
fanf
deleted the
bug_14312/missing_eventlogs_for_technique_editor_action_and_technique_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14312
the provided commitid is the revision tree one, not a real commit id. The problem is that we totally can have several git commit without a reload, and to we can only log the state of the git when the reload is done. It is not possible to change that without changing all the logic on technique library, which is extremelly dangerous.