Fixes #14536: Add a button to show/hide Directives and Groups tree in Rule details #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really, really good but I think we need a little bit more information on the directive/group before merging, at least link toward said objects (and perhaps description/ policy mode). |
RaphaelGauthier
force-pushed
the
ust_14536/add_a_button_to_show_hide_directives_and_groups_tree_in_rule_details
branch
from
8243c72
to
c503ddc
Compare
|
Commit modified |
fanf
requested changes
Mar 29, 2019
| for (var o in $scope.directives) { | ||
| arr.push({"id":o, "name": $scope.directives[o] }); | ||
| } | ||
| for (var o in $scope.directives) { |
There was a problem hiding this comment.
It seems that that part is not working as expected. Directive can't be selected / unselected (groups work)
RaphaelGauthier
force-pushed
the
ust_14536/add_a_button_to_show_hide_directives_and_groups_tree_in_rule_details
branch
from
c503ddc
to
431b8aa
Compare
|
PR rebased |
RaphaelGauthier
force-pushed
the
ust_14536/add_a_button_to_show_hide_directives_and_groups_tree_in_rule_details
branch
from
431b8aa
to
29169b7
Compare
|
Commit modified |
RaphaelGauthier
force-pushed
the
ust_14536/add_a_button_to_show_hide_directives_and_groups_tree_in_rule_details
branch
from
29169b7
to
77cb5e6
Compare
|
Commit modified |
|
Perfect! |
fanf
approved these changes
Mar 29, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14536