Fixes #14586: Update relay component #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
a313238
to
621b2f5
Compare
|
Commit modified |
ncharles
reviewed
Apr 4, 2019
| logs: log_entries >> | ||
| rudder_report_begin >> | ||
| policy: take_until_and_consume_s!("@@") >> | ||
| event_type: take_until_and_consume_s!("@@") >> | ||
| rule_id: take_until_and_consume_s!("@@") >> | ||
| directive_id: take_until_and_consume_s!("@@") >> | ||
| serial: take_until_and_consume_s!("@@") >> | ||
| serial: map_res!(take_until_and_consume_s!("@@"), parse_i32) >> |
There was a problem hiding this comment.
meaning: there is no way the serial can be set to something else than 0 in Rudder 4.3 and more
There was a problem hiding this comment.
The idea is to allow reusing this field if we want it in the future, without having to upgrade all relays.
There was a problem hiding this comment.
(specially as it is cheap and just as simple to implement)
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
621b2f5
to
3027802
Compare
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
3027802
to
c0c9ac3
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
bf7e401
to
1271c36
Compare
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
1271c36
to
30e70de
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
2 times, most recently
from
aed0582
to
49babf5
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
976eafb
to
33fe570
Compare
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
33fe570
to
465e764
Compare
|
PR rebased |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
465e764
to
85daa29
Compare
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
85daa29
to
c483f14
Compare
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
c483f14
to
66d4f4b
Compare
|
Commit modified |
Fixes #14586: Update relay component
|
Commit modified |
1 similar comment
|
Commit modified |
amousset
force-pushed
the
arch_14586/update_relay_component
branch
from
130bc60
to
92177be
Compare
|
Commit modified |
Fixes #14586: Update relay component
|
Commit modified |
|
OK, squash merging this PR |
1 similar comment
|
OK, squash merging this PR |
|
Commit modified |
1 similar comment
|
Commit modified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14586