Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14770: Invalid comparision of String and Option[String] in HistorizationService #2203

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Fixes #14770: Invalid comparision of String and Option[String] in HistorizationService #2203

merged 1 commit into from
Apr 25, 2019

Conversation

ncharles
Copy link
Member

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2203
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/9528/console)

@ncharles
Copy link
Member Author

OK, merging this PR

@ncharles ncharles merged commit 805cc3b into Normation:branches/rudder/4.1 Apr 25, 2019
@ncharles
Copy link
Member Author

OK, merging this PR

@ncharles
Copy link
Member Author

interestingly, in upper branch it was easier: comparing entry with Some(value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@ncharles @Normation-Quality-Assistant @VinceMacBuche