Fixes #4480: When restoring archive (full or groups) dynamic groups are created empty #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Apr 25, 2019
|
|
||
| override def computeDynGroup (group : NodeGroup): Box[NodeGroup] = { | ||
| for { | ||
| _ <- if(group.isDynamic) Full("OK") else Failure("Can not update a not dynamic group") |
There was a problem hiding this comment.
i'm nitpicking, but could you align the <- ?
… groups are created empty
VinceMacBuche
force-pushed
the
bug_4480/when_restoring_archive_full_or_groups_dynamic_groups_are_created_empty
branch
from
fa94aa0
to
6b7a912
Compare
|
Commit modified |
ncharles
approved these changes
Apr 25, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/4480