-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #14878: Add a contribution guide to the Rudder repo #2219
Fixes #14878: Add a contribution guide to the Rudder repo #2219
Conversation
CONTRIBUTING.adoc
Outdated
using the https://www.rudder-project.org/mailman/listinfo/rudder-dev[rudder-dev] | ||
mailing list. | ||
|
||
NOTE: Contribution to Rudder requires a https://www.rudder.io/en/expand/contribute/#panel-2422-8-0-1[CLA/CCLA]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say:
Large contribution on Rudder may requires...
Small / trivial contrib don't require the CCLA, and we don't want to frighten someone who just want to correct a typo in somewhere.
|
||
NOTE: Contribution to Rudder requires a https://www.rudder.io/en/expand/contribute/#panel-2422-8-0-1[CLA/CCLA]. | ||
|
||
== Development workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before that, I would had: "documentation workflow" with "you can just click edit on the doc". To start with the easy parts :)
CONTRIBUTING.adoc
Outdated
|
||
NOTE: Some tooling repositories only have a `master` branch. | ||
|
||
All changes need to be done in the oldest relevant branch (i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/changes need to/bug correction should/
And perhaps something explaining that we can assist them if they fear to deal with that oldest-branch rule.
``` | ||
rudder-dev update | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should tell here that there's a configuration file to update with github token.
Commit modified |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
de72c5a
to
6c877f5
Compare
https://issues.rudder.io/issues/14878