Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14878: Add a contribution guide to the Rudder repo #2219

Conversation

amousset
Copy link
Member

using the https://www.rudder-project.org/mailman/listinfo/rudder-dev[rudder-dev]
mailing list.

NOTE: Contribution to Rudder requires a https://www.rudder.io/en/expand/contribute/#panel-2422-8-0-1[CLA/CCLA].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say:
Large contribution on Rudder may requires...
Small / trivial contrib don't require the CCLA, and we don't want to frighten someone who just want to correct a typo in somewhere.


NOTE: Contribution to Rudder requires a https://www.rudder.io/en/expand/contribute/#panel-2422-8-0-1[CLA/CCLA].

== Development workflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before that, I would had: "documentation workflow" with "you can just click edit on the doc". To start with the easy parts :)


NOTE: Some tooling repositories only have a `master` branch.

All changes need to be done in the oldest relevant branch (i.e.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/changes need to/bug correction should/
And perhaps something explaining that we can assist them if they fear to deal with that oldest-branch rule.

```
rudder-dev update
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should tell here that there's a configuration file to update with github token.

@amousset
Copy link
Member Author

amousset commented Jun 3, 2019

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2219
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/10865/console)

@amousset
Copy link
Member Author

amousset commented Jun 3, 2019

OK, squash merging this PR

@amousset amousset force-pushed the arch_14878/add_a_contribution_guide_to_the_rudder_repo branch from de72c5a to 6c877f5 Compare June 3, 2019 14:21
@amousset amousset merged commit 6c877f5 into Normation:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants