Fixes #14924: Cleanup unreferenced software #2231
Conversation
| Full(Unit) | ||
| case Failure(msg, exception, chain) => mutSetSoftwares = Failure(msg, exception, chain) // otherwise the time is wrong | ||
| } | ||
| } |
There was a problem hiding this comment.
this ain't pretty, yet its more efficient
[2019-05-23 13:00:06] DEBUG com.normation.inventory.ldap.core.SoftwareServiceImpl - All softwares id in nodes fetched: 37953 softwares id in 10029ms, compared to what is in the TODO below
[2019-05-23 12:55:17] DEBUG com.normation.inventory.ldap.core.SoftwareServiceImpl - All softwares id in nodes fetched: 37953 softwares id in 15197ms
There was a problem hiding this comment.
this code is surely non idiomatic, and i fail to improve it
ncharles
force-pushed
the
bug_14924/cleanup_unreferenced_software
branch
from
fe7bf28
to
4bb4a0d
Compare
|
Commit modified |
| @@ -146,7 +146,7 @@ along with Rudder. If not, see <http://www.gnu.org/licenses/>. | |||
| are doing. | |||
| --> | |||
|
|
|||
| <root level="info"> | |||
| <root level="debug"> | |||
| @@ -360,7 +360,7 @@ along with Rudder. If not, see <http://www.gnu.org/licenses/>. | |||
| ================ | |||
| This logger is in charge of all scheduled jobs and batches | |||
| --> | |||
| <logger name="scheduledJob" level="info" additivity="false"> | |||
| <logger name="scheduledJob" level="debug" additivity="false"> | |||
ncharles
force-pushed
the
bug_14924/cleanup_unreferenced_software
branch
from
4bb4a0d
to
4517d59
Compare
|
Commit modified |
|
|
||
| batchedNodes = nodes.grouped(50) | ||
|
|
||
| _ = batchedNodes.foreach { nodeEntries: Seq[LDAPEntry] => |
There was a problem hiding this comment.
it should not be a foreach, else we loose the maybe Failure: res <- sequence(batchedNodes) { .... }
There was a problem hiding this comment.
i tried using a sequence on batchedNodes, without success (it's an iterator, I cannot sequence it)
There was a problem hiding this comment.
You can do:
batchedNodes = con.searchSub(acceptedDit.NODES.dn.getParent, IS(OC_NODE), A_NODE_UUID).grouped(50).toSeq
res <- sequence(batchedNodes) { nodeEntries: Seq[LDAPEntry] =>
You still process nodes 50 by 50, and don't hold more node ids than previously
ncharles
force-pushed
the
bug_14924/cleanup_unreferenced_software
branch
from
db1e062
to
fd62862
Compare
|
Commit modified |
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
https://issues.rudder.io/issues/14924