Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15207: Error when modifying a Directive when having the Change Request plugin #2303

Closed
wants to merge 1 commit into from
Closed

Fixes #15207: Error when modifying a Directive when having the Change Request plugin #2303

wants to merge 1 commit into from

Conversation

ncharles
Copy link
Member

@ncharles
Copy link
Member Author

caution: i didn't test it

@fanf
Copy link
Member

fanf commented Jul 11, 2019

The proposed change only normalise the log message, not the comparison, so it won't work. I will do the correction again.

@fanf fanf closed this Jul 11, 2019
@fanf
Copy link
Member

fanf commented Jul 11, 2019

Superseeded by #2304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ncharles @fanf