Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15212: Generate a file on root server containing all nodes certificate #2313

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Fixes #15212: Generate a file on root server containing all nodes certificate #2313

merged 1 commit into from
Jul 19, 2019

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 17, 2019

@fanf
Copy link
Member Author

fanf commented Jul 17, 2019

We need to trigger a SIGUP to relayd after writing the file

@fanf
Copy link
Member Author

fanf commented Jul 17, 2019

PR rebased

@fanf fanf force-pushed the arch_15212/generate_a_file_on_root_server_containing_all_nodes_certificate branch from 2ea6f32 to b3ace77 Compare July 17, 2019 21:32
@fanf
Copy link
Member Author

fanf commented Jul 17, 2019

PR updated with a new commit

VinceMacBuche
VinceMacBuche previously approved these changes Jul 18, 2019
View reviewed changes
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2313
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12456/console)

@fanf
Copy link
Member Author

fanf commented Jul 19, 2019

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2313
-- Your faithful QA
Kant merge: "Science is organized knowledge. Wisdom is organized life."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12509/console)

@fanf
Copy link
Member Author

fanf commented Jul 19, 2019

OK, squash merging this PR

@fanf fanf force-pushed the arch_15212/generate_a_file_on_root_server_containing_all_nodes_certificate branch from a1056b1 to 4547f3a Compare July 19, 2019 14:18
@fanf
Copy link
Member Author

fanf commented Jul 19, 2019

OK, merging this PR

@fanf fanf merged commit 4547f3a into Normation:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@fanf @Normation-Quality-Assistant @VinceMacBuche