Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15313: Policy generation error is not clear in log anymore #2344

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 25, 2019

@fanf fanf requested a review from VinceMacBuche July 25, 2019 14:21
@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'master' set up to track remote branch 'master' from 'NRM'.
Your branch is up to date with 'NRM/master'.
Already up to date.
Already up to date.
[...]

-- stderr --
From github.com:fanf/rudder
 * [new branch]          bug_15313/policy_generation_error_is_not_clear_in_log_anymore -> bug_15313/policy_generation_error_is_not_clear_in_log_anymore_pr
Switched to branch 'master'
Switched to a new branch 'master_test'
+ '[' --merge = --rust ']'
+ '[' --merge = --scala ']'
+ webapp/sources/rudder/rudder-core/src/test/resources/hooks.d/test-hooks.sh

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder/pull/2344 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/12840/console)

@fanf
Copy link
Member Author

fanf commented Jul 25, 2019

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2344
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12842/console)

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2344
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12843/console)

@fanf
Copy link
Member Author

fanf commented Jul 25, 2019

OK, squash merging this PR

@fanf fanf force-pushed the bug_15313/policy_generation_error_is_not_clear_in_log_anymore branch from 0701b2c to 47c3677 Compare July 25, 2019 14:26
@fanf fanf merged commit 47c3677 into Normation:master Jul 25, 2019
@fanf fanf deleted the bug_15313/policy_generation_error_is_not_clear_in_log_anymore branch March 15, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants