-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #15469: Verifying signatures correctly in shared-files API #2400
Fixes #15469: Verifying signatures correctly in shared-files API #2400
Conversation
HashType::from_str(hash_type).unwrap(), | ||
&meta.digest, | ||
) | ||
.unwrap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to properly handle the error here
relay/sources/relayd/Cargo.toml
Outdated
serde = { version = "1.0", features = ["derive"] } | ||
serde_json = "1.0" | ||
nom = "5.0" | ||
serde = { version = "1.0.98", features = ["derive"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why adding precise versions here? Semver should be enough, and this makes it a bit harder to upgrade direct dependencies, while providing no more control than Cargo.lock.
Commit modified |
relay/sources/relayd/Cargo.toml
Outdated
@@ -23,41 +23,42 @@ serde = { version = "1.0", features = ["derive"] } | |||
serde_json = "1.0" | |||
nom = "5.0" | |||
# Could use native lib instead, but maybe not prod-ready | |||
flate2 = { version = "1.0", features = ["zlib"], default-features = false } | |||
diesel = { version = "1.4", features = ["postgres", "chrono", "r2d2"] } | |||
flate2 = { version = "1.0.11", features = ["zlib"], default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for all other dependencies, why adding a precise version (which is already fixed in Cargo.lock)
Commit modified |
relay/sources/relayd/Cargo.toml
Outdated
tracing-fmt = { git = "https://github.com/tokio-rs/tracing" } | ||
tracing-log = { git = "https://github.com/tokio-rs/tracing" } | ||
tracing-fmt = "0.0.1-alpha.3" | ||
tracing-log = "0.0.1-alpha.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be part of this PR, can your rebase it ?
Commit modified |
OK, merging this PR |
https://issues.rudder.io/issues/15469