Fixes #15469: Verifying signatures correctly in shared-files API #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Aug 16, 2019
| HashType::from_str(hash_type).unwrap(), | ||
| &meta.digest, | ||
| ) | ||
| .unwrap() |
There was a problem hiding this comment.
We need to properly handle the error here
amousset
reviewed
Aug 16, 2019
relay/sources/relayd/Cargo.toml
Outdated
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = "1.0" | ||
| nom = "5.0" | ||
| serde = { version = "1.0.98", features = ["derive"] } |
There was a problem hiding this comment.
Why adding precise versions here? Semver should be enough, and this makes it a bit harder to upgrade direct dependencies, while providing no more control than Cargo.lock.
|
Commit modified |
amousset
reviewed
Aug 16, 2019
relay/sources/relayd/Cargo.toml
Outdated
| @@ -23,41 +23,42 @@ serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| nom = "5.0" | |||
| # Could use native lib instead, but maybe not prod-ready | |||
| flate2 = { version = "1.0", features = ["zlib"], default-features = false } | |||
| diesel = { version = "1.4", features = ["postgres", "chrono", "r2d2"] } | |||
| flate2 = { version = "1.0.11", features = ["zlib"], default-features = false } | |||
There was a problem hiding this comment.
Same for all other dependencies, why adding a precise version (which is already fixed in Cargo.lock)
|
Commit modified |
amousset
reviewed
Aug 16, 2019
relay/sources/relayd/Cargo.toml
Outdated
| tracing-fmt = { git = "https://github.com/tokio-rs/tracing" } | ||
| tracing-log = { git = "https://github.com/tokio-rs/tracing" } | ||
| tracing-fmt = "0.0.1-alpha.3" | ||
| tracing-log = "0.0.1-alpha.1" |
There was a problem hiding this comment.
This should not be part of this PR, can your rebase it ?
|
Commit modified |
amousset
approved these changes
Aug 16, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15469