Fixes #15531: Add an Interface to select reporting protocol #2411
Conversation
| @@ -174,26 +174,52 @@ <h3 class="page-title">Security</h3> | |||
| </form> | |||
| </div> | |||
| </div> | |||
| <div class="inner-portlet"> | |||
| <h3 class="page-title">Reporting protocol</h3> | |||
| <div class="lift:administration.PropertiesManagement.reportProtocolSection" id="reportProtocolForm"> | |||
There was a problem hiding this comment.
there need an introduction text about the protocol, that Syslog is the historical one, but in 5.1 HTTPS is available, better, faster, stronger, safer. Or something like that
VinceMacBuche
force-pushed
the
ust_15531/add_an_interface_to_select_reporting_protocol
branch
from
5da894b
to
f77a673
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_15531/add_an_interface_to_select_reporting_protocol
branch
from
f77a673
to
82ddd3a
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_15531/add_an_interface_to_select_reporting_protocol
branch
from
82ddd3a
to
32831b1
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_15531/add_an_interface_to_select_reporting_protocol
branch
from
32831b1
to
f31de82
Compare
|
Commit modified |
|
|
||
| def noModif = ( | ||
| for { | ||
| initSyslog <- initSyslogProtocol |
There was a problem hiding this comment.
could you correct the indentation ?
| configService.set_rudder_syslog_protocol_disabled(disabledSyslog, actor, None).toBox.foreach(updateOk => initDisabledSyslog = Full(disabledSyslog)) | ||
|
|
||
| // start a promise generation, Since we check if there is change to save, if we got there it mean that we need to redeploy | ||
| startNewPolicyGeneration |
There was a problem hiding this comment.
the configService should take care of starting the new policy generation if value changed (at least I think that's how it works)
There was a problem hiding this comment.
need to look at the service!
| reportProtocol = protocol | ||
| protocol match { | ||
| case AgentReportingHTTPS => | ||
|
|
There was a problem hiding this comment.
could you remove this blank line which is misleading ?
|
|
||
| val checkboxInitValue = initReportsProtocol == SyslogUDP | ||
| val zip : Box[(AgentReportingProtocol,Boolean)] = (initReportProtocol,initDisabledSyslog) match { |
| val (label,value) = labelAndValue(protocol,disabledSyslog) | ||
| val inputId = value + "-id" | ||
| val ajaxCall = SHtml.ajaxCall(Str(""), _ => displayDisableSyslogSectionJS(value) & check)._2.toJsCmd | ||
| val inputCheck = if (initReport == protocol && initDisabled == disabledSyslog) { |
There was a problem hiding this comment.
why the condition on disabledSyslog ?
There was a problem hiding this comment.
(or on protocol - i don't get why there is both)
There was a problem hiding this comment.
Because we manage both properties with that input ... it' a three state select
With
Https only (so https + disabled syslog)
https with syslog support (so https + enable syslog)
Syslog only (so Syslog and enable syslog (obviously)
VinceMacBuche
force-pushed
the
ust_15531/add_an_interface_to_select_reporting_protocol
branch
from
f31de82
to
29c6891
Compare
|
Commit modified |
|
OK, merging this PR |
https://issues.rudder.io/issues/15531