New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #15551: Fix systemctl call in Makefile #2418
Fixes #15551: Fix systemctl call in Makefile #2418
Conversation
relay/sources/Makefile
Outdated
@@ -119,7 +119,7 @@ install: build | |||
# Install service | |||
install -m 644 systemd/rudder-relayd.service $(DESTDIR)/usr/lib/systemd/system/rudder-relayd.service | |||
# Sandboxing if compatible | |||
[ $$(systemctl --version | head -1 | cut -d' ' -f2) -gt 232 ] && sed '/\[Service\]/ r systemd/rudder-relayd-hardening' $(DESTDIR)/usr/lib/systemd/system/rudder-relayd.service | |||
[ $$(/bin/systemctl --version | head -1 | cut -d' ' -f2) -gt 232 ] && sed '/\[Service\]/ r systemd/rudder-relayd-hardening' $(DESTDIR)/usr/lib/systemd/system/rudder-relayd.service || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work on some debian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover could you add the build-dependency to systemd in debian/control ?
PR updated with a new commit |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
https://issues.rudder.io/issues/15551