Fixes #15590: Renaming/moving technique category fails in several way #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
VinceMacBuche
requested changes
Aug 30, 2019
| for { | ||
| cat <- getParentTechniqueCategory_forTechnique(id) | ||
| path <- sequence(cat.id.getIdPathFromRoot) { currentCatId => | ||
| getTechniqueCategory(currentCatId) ?~! "'%s' category was not found but should be a parent of '%s'".format(currentCatId, cat.id) | ||
| getTechniqueCategory(currentCatId) ?~! "'%s' category was not found but should be a parent of '%s'".format( |
There was a problem hiding this comment.
You could have switch to a string interpolation ! and more importantly you should use currentCatId.,name and cat.id.name
|
PR updated with a new commit |
ncharles
approved these changes
Aug 30, 2019
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_15590/trying_to_create_or_move_technique_category_into_root_directory_fails
branch
from
ca6ee4c
to
d633db4
Compare
fanf
deleted the
bug_15590/trying_to_create_or_move_technique_category_into_root_directory_fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15590