Fixes #15608: When creating a rule via the API the id parameter is only read from url parameters, and not from json #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
force-pushed
the
bug_15608/when_creating_a_rule_via_the_api_the_id_parameter_is_only_read_from_url_parameters_and_not_from_json
branch
from
e09bfb0
to
9643bfc
Compare
|
Commit modified |
fanf
requested changes
Sep 3, 2019
| } else { | ||
| val restRule = restExtractor.extractRule(req.params) | ||
| apiV2.createRule(restRule, req) | ||
| implicit var action = "createRule" |
There was a problem hiding this comment.
no implicit var please, each one is terrible for understanding, both together...
Please only implicit val
| } | ||
|
|
||
| actionResponse(response, req, "Could not create Rule", None, authzToken.actor) |
There was a problem hiding this comment.
Why None here? Shouldn't it depend of the kind of response?
…ly read from url parameters, and not from json
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_15608/when_creating_a_rule_via_the_api_the_id_parameter_is_only_read_from_url_parameters_and_not_from_json
branch
from
9643bfc
to
4637177
Compare
fanf
approved these changes
Sep 3, 2019
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15608