Fixes #15676: Remove Map#keySet because of memory not freed #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will wait for |
ncharles
reviewed
Sep 11, 2019
| @@ -188,9 +188,9 @@ class HistorizationServiceImpl( | |||
| } | |||
| }.toSeq.map { case (t,fat,d) => (d, fat.toActiveTechnique, t) } | |||
|
|
|||
| val stringDirectiveIds = directives.keySet.map( _.value) | |||
| val stringDirectiveIds = directives.keysIterator.toSet.map( _.value) | |||
There was a problem hiding this comment.
wow, this fails
[ERROR] /root/dev/rudder/webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/services/eventlog/HistorizationService.scala:191: error: missing parameter type for expanded function ((x$4: ) => x$4.value)
[ERROR] val stringDirectiveIds = directives.keysIterator.toSet.map( _.value)
[ERROR] ^
i have no idea why ...
There was a problem hiding this comment.
doing it in 2 steps fixes the issues
val directiveSet = directives.keysIterator.toSet
val stringDirectiveIds = directiveSet.map( _.value)
ncharles
reviewed
Sep 11, 2019
| @@ -289,7 +289,7 @@ object QSLdapBackend { | |||
|
|
|||
| if(m.size != QSAttribute.all.size) { | |||
| throw new IllegalArgumentException("Be carefull, it seems that the list of attributes in QSAttribute was modified, but not the list of name mapping" + | |||
| s"Please check for '${(m.keySet.diff(QSAttribute.all)++QSAttribute.all.diff(m.keySet)).mkString("', '")}'" | |||
| s"Please check for '${(m.keysIterator.toSet.diff(QSAttribute.all)++QSAttribute.all.diff(m.keysIterator)).mkString("', '")}'" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15676