Fixes #15713: Show log informations next to reports and full compliance report #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
VinceMacBuche
force-pushed
the
bug_15713/show_log_informations_next_to_reports_and_full_compliance_report
branch
from
7cd18fc
to
6c9bbaa
Compare
|
PR rebased |
1 similar comment
|
PR rebased |
VinceMacBuche
force-pushed
the
bug_15713/show_log_informations_next_to_reports_and_full_compliance_report
branch
2 times, most recently
from
84001a8
to
4358be6
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_15713/show_log_informations_next_to_reports_and_full_compliance_report
branch
2 times, most recently
from
04aaae3
to
4e33cb9
Compare
|
Commit modified |
fanf
requested changes
Oct 9, 2019
| @@ -217,6 +219,7 @@ case class ReportLine ( | |||
|
|
|||
| JsObj( | |||
| ( "executionDate", executionDate.toString("yyyy-MM-dd HH:mm:ss") ) | |||
| , ( "runDate", runDate.toString("yyyy-MM-dd HH:mm:ss") ) | |||
There was a problem hiding this comment.
Can you use either ISODateTimeFormater .dateTime or our date formatter service with "getDisplayDate" ? We need at least timezone and it's more consistant that way
|
PR rebased |
VinceMacBuche
force-pushed
the
bug_15713/show_log_informations_next_to_reports_and_full_compliance_report
branch
from
4e33cb9
to
63913fd
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_15713/show_log_informations_next_to_reports_and_full_compliance_report
branch
from
63913fd
to
7e60c46
Compare
|
When we first come to the page, all event logs are loaded, which leads to a very bad experience (huge latency...). |
|
bad PR, sorry ! |
fanf
approved these changes
Oct 14, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15713
Replacing previous PR: #2493