Fixes #15775: Performance problems with ZIO #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
fanf
force-pushed
the
bug_15775/performance_problems_with_zio
branch
from
84e1369
to
2def956
Compare
|
PR updated with a new commit |
fanf
force-pushed
the
bug_15775/performance_problems_with_zio
branch
from
d20f859
to
fdbc8e6
Compare
|
PR rebased |
ncharles
reviewed
Oct 15, 2019
| _ <- counters.sumTimeExpandeVar.update(_ + t2_1 - t2_0) | ||
| // And now, for each variable, eval - if needed - the result | ||
| expandedVars <- expandedVariables.accumulate { case (k, v) => | ||
| //js lib is specific to the node os, bind here to not leak eval between vars |
There was a problem hiding this comment.
i think this could be done outside the flteredDraft.accumulate, as we are dealing node per node
but i don't think it would change much perf, but surely allocate less objects
ncharles
approved these changes
Oct 15, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15775