Fixes #16063: Enable backtrace in relayd #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
arch_16063/enable_backtrace_in_relayd
branch
from
3444873
to
217d0eb
Compare
|
Commit modified |
relay/sources/relayd/src/relayd.rs
Outdated
| // and can be helpful to troubleshoot production crashes | ||
| env::set_var("RUST_BACKTRACE", "1"); | ||
|
|
||
| assert!(false); |
There was a problem hiding this comment.
Why do you need the assert ?
There was a problem hiding this comment.
To test that crashes actually produce backtraces 🙃
|
Commit modified |
amousset
force-pushed
the
arch_16063/enable_backtrace_in_relayd
branch
from
217d0eb
to
bdbc31b
Compare
VinceMacBuche
approved these changes
Oct 25, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16063