Fixes #15864: add an option to prevent backup of node policy at the end of policy generation #2561
Conversation
…nd of policy generation
|
Commit modified |
ncharles
force-pushed
the
bug_15864/add_an_option_to_prevent_backup_of_node_policy_at_the_end_of_policy_generation
branch
from
79ffe1a
to
0f12fd5
Compare
| * Move the generated promises from the new folder to their final folder, backuping previous promises in the way | ||
| * @param folder : (Container identifier, (base folder, new folder of the policies, backup folder of the policies) ) | ||
| * Move the generated policies from the new folder to their final folder, backuping previous policies in the way | ||
| * if backupPoliciesAtEndOfGeneration is true, otherwise removing preivous policies |
| logger.trace("Backuping old promises from %s to %s ".format(baseFolder, backupFolder)) | ||
| backupNodeFolder(baseFolder, backupFolder) | ||
| if (backupPoliciesAtEndOfGeneration) { | ||
| logger.trace("Backuping old policies from %s to %s ".format(baseFolder, backupFolder)) |
There was a problem hiding this comment.
could you change it to: s"Backuping old policies from ${baseFolder} to ${backupFolder}" for consistency ?
| backupNodeFolder(baseFolder, backupFolder) | ||
| } else { | ||
| logger.trace(s"Deleting old policies in ${baseFolder}") | ||
| deleteNodeFolder(baseFolder) |
There was a problem hiding this comment.
shouldn't we also delete backupFolder if it exits from a previous generation with a different backup strategy?
Else, people may become confuse when/if they find back the olds generated files at some point.
There was a problem hiding this comment.
yes, that's a good idea
|
here is something odd here: with the delete
with the move
|
|
delete: [2019-10-28 23:24:06] DEBUG policy.generation - Policies moved to their final position in 354937 ms |
| /** | ||
| * Delete the previous node policies folder | ||
| */ | ||
| private[this] def deleteNodeFolder(nodeFolder: String): Unit = { |
There was a problem hiding this comment.
actually, we could skip it as moveNewNodeFolder does the deletion of dest if it exists
|
So, what do we do with that one? Close it as "not a good idea finaly?" |
|
We will close that PR for now, until we have better understanding of the underlying perf. |
https://issues.rudder.io/issues/15864