Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16232: Directive based on a multivalued technique are not marked overriden #2625

Merged
merged 1 commit into from Nov 22, 2019
Merged

Fixes #16232: Directive based on a multivalued technique are not marked overriden #2625

merged 1 commit into from Nov 22, 2019

Conversation

fanf
Copy link
Member

@fanf fanf commented Nov 21, 2019

ncharles
ncharles requested changes Nov 22, 2019
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you correct the permissions ? Otherwise it is fine

@VinceMacBuche
Copy link
Member

Test fail because of

10:34:23 Hooks is not executable: ./webapp/sources/rudder/rudder-core/src/main/resources/hooks.d/policy-generation-finished/50-reload-policy-file-server

@fanf
Copy link
Member Author

fanf commented Nov 22, 2019

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2625
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/17447/console)

@fanf
Copy link
Member Author

fanf commented Nov 22, 2019

OK, squash merging this PR

@fanf fanf force-pushed the bug_16232/directive_not_written_skipped_even_with_11917_correction branch from 5761ae9 to a90b640 Compare November 22, 2019 16:30
@fanf fanf merged commit a90b640 into Normation:branches/rudder/5.0 Nov 22, 2019
@fanf fanf deleted the bug_16232/directive_not_written_skipped_even_with_11917_correction branch March 15, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles requested changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
4 participants
@fanf @VinceMacBuche @Normation-Quality-Assistant @ncharles