Fixes #16374: Race condition in technique variable filling #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Dec 9, 2019
|
OK, merging this PR |
ncharles
reviewed
Dec 10, 2019
| } | ||
| } | ||
|
|
||
| def getTemplateFromContent(templateName: String,content: String): IOResult[SynchronizedFileTemplate] = { | ||
| for { | ||
| c <- semaphore.withPermit(cache.get(content) match { | ||
| semaphore.withPermit(for { |
There was a problem hiding this comment.
here, you are locking with the same semaphore than fill ; you should have a distrinct semaphore (if possible)
There was a problem hiding this comment.
they have the same name but there is two ZioRuntime.unsafeRun(Semaphore.make(1)) so there are not the same (actually, there is one semaphore for each SynchronizedFileTemplate, so for each fill)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16374