Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16503: Normalize loggers for timing performance on write promises #2703

Conversation

fanf
Copy link
Member

@fanf fanf commented Jan 8, 2020

@fanf fanf requested a review from ncharles January 8, 2020 20:53
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you'll need to modify logback.xml
also, it's a good idea to list the effective changes so that users upgrading can easily edit their logger

@fanf
Copy link
Member Author

fanf commented Jan 9, 2020

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_16503/normalize_loggers_for_timing_performance_on_write_promises branch from 639bce5 to ac23b63 Compare January 12, 2020 16:54
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit ac23b63 into Normation:branches/rudder/6.0 Jan 12, 2020
@fanf fanf deleted the bug_16503/normalize_loggers_for_timing_performance_on_write_promises branch March 15, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants